Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DD-1755 #11

Merged
merged 19 commits into from
Jan 21, 2025
Merged

DD-1755 #11

merged 19 commits into from
Jan 21, 2025

Conversation

janvanmansum
Copy link
Contributor

Fixes DD-1755

Description of changes

How to test

Related PRs

(Add links)
*

Notify

@DANS-KNAW/core-systems

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 53.80711% with 91 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (7d4c7e9) to head (14a250d).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...w/dans/dvingest/core/bagprocessor/FilesEditor.java 64.28% 5 Missing and 10 partials ⚠️
...nl/knaw/dans/dvingest/core/DataverseIngestBag.java 0.00% 14 Missing ⚠️
.../dans/dvingest/core/bagprocessor/BagProcessor.java 0.00% 11 Missing ⚠️
.../dans/dvingest/core/yaml/tasklog/EditFilesLog.java 45.00% 11 Missing ⚠️
...ngest/core/bagprocessor/DatasetVersionCreator.java 88.33% 0 Missing and 7 partials ⚠️
.../knaw/dans/dvingest/core/yaml/tasklog/TaskLog.java 0.00% 7 Missing ⚠️
...naw/dans/dvingest/core/DataverseIngestDeposit.java 0.00% 6 Missing ⚠️
...ns/dvingest/core/yaml/tasklog/EditMetadataLog.java 0.00% 4 Missing ⚠️
.../knaw/dans/dvingest/core/yaml/tasklog/InitLog.java 33.33% 3 Missing and 1 partial ⚠️
...w/dans/dvingest/core/yaml/tasklog/TaskLogRoot.java 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     51.30%   52.20%   +0.90%     
- Complexity      620      669      +49     
============================================
  Files           124      132       +8     
  Lines          3019     3145     +126     
  Branches        235      235              
============================================
+ Hits           1549     1642      +93     
- Misses         1308     1330      +22     
- Partials        162      173      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janvanmansum janvanmansum merged commit ec8e8b7 into DANS-KNAW:master Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janvanmansum